Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/79459
Change subject: Fix translation checks when using non-primary message groups
......................................................................
Fix translation checks when using non-primary message groups
Instead of using the supplied message group, use the message
cache to find out the primary message group and use its checker.
Change-Id: I8c89c5b141d918b852c0c6ca74a5239533fe4015
---
M utils/TranslationHelpers.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/59/79459/1
diff --git a/utils/TranslationHelpers.php b/utils/TranslationHelpers.php
index 15792a6..82e4772 100644
--- a/utils/TranslationHelpers.php
+++ b/utils/TranslationHelpers.php
@@ -870,7 +870,9 @@
return null;
}
- $checker = $this->group->getChecker();
+ // We need to get the primary group of the message. It may
differ from
+ // the supplied group (aggregate groups, dynamic groups).
+ $checker = $this->handle->getGroup()->getChecker();
if ( !$checker ) {
return null;
}
--
To view, visit https://gerrit.wikimedia.org/r/79459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c89c5b141d918b852c0c6ca74a5239533fe4015
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
