JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/79814
Change subject: Fix tap event fallback
......................................................................
Fix tap event fallback
Previously the click event callback was called before mouseup which
led to JS errors.
Change-Id: I3c31199fb1d7d3a5eec26efd20aca4551700d63a
---
M javascripts/externals/micro.tap.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/14/79814/1
diff --git a/javascripts/externals/micro.tap.js
b/javascripts/externals/micro.tap.js
index f3f997a..1cce8fc 100644
--- a/javascripts/externals/micro.tap.js
+++ b/javascripts/externals/micro.tap.js
@@ -29,7 +29,8 @@
}).
on('touchend', handleTap);
} else {
- $window.on('mouseup', handleTap);
+ // need to set useCapture to true so that this runs before the click
callback
+ window.addEventListener('mouseup', handleTap, true);
}
}(jQuery));
--
To view, visit https://gerrit.wikimedia.org/r/79814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c31199fb1d7d3a5eec26efd20aca4551700d63a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
