Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/79841


Change subject: Bug 52361: Fix reference weirdness in Opera Mobile
......................................................................

Bug 52361: Fix reference weirdness in Opera Mobile

I'd love to know why this fixes the problem... but I don't.
Yet it does.
<3 JavaScript quirks

Change-Id: Idce415b321bf7a9c4c4cab023d9eaeb884b3a583
---
M javascripts/common/Overlay.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/41/79841/1

diff --git a/javascripts/common/Overlay.js b/javascripts/common/Overlay.js
index 2737c16..f3c79f5 100644
--- a/javascripts/common/Overlay.js
+++ b/javascripts/common/Overlay.js
@@ -10,7 +10,8 @@
                template: M.template.get( 'overlay' ),
                className: 'mw-mf-overlay',
                closeOnBack: false,
-               appendTo: 'body',
+               // use document.body rather than 'body' - for some reasons this 
has odd consequences on Opera Mobile (see bug 52361)
+               appendTo: document.body,
                initialize: function( options ) {
                        var self = this;
                        options = options || {};

-- 
To view, visit https://gerrit.wikimedia.org/r/79841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idce415b321bf7a9c4c4cab023d9eaeb884b3a583
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to