jenkins-bot has submitted this change and it was merged.
Change subject: ext.echo.special: Move #firstHeading styling from JS to CSS
......................................................................
ext.echo.special: Move #firstHeading styling from JS to CSS
Also some code cleanup in the part about converting subtitle links
into header icons.
Change-Id: I25eacb9c512fd6883a65df3af97608749b53b228
---
M modules/special/ext.echo.special.css
M modules/special/ext.echo.special.js
2 files changed, 11 insertions(+), 9 deletions(-)
Approvals:
Bsitu: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/special/ext.echo.special.css
b/modules/special/ext.echo.special.css
index 27cdc19..5ae9800 100644
--- a/modules/special/ext.echo.special.css
+++ b/modules/special/ext.echo.special.css
@@ -7,7 +7,14 @@
max-width: 600px;
}
-/* Special styles to use if we're converting the subtitle links into header
icons */
+/* Custom header styling for Vector and Monobook skins */
+.skin-vector #firstHeading,
+.skin-monobook #firstHeading {
+ margin-left: 50px;
+ max-width: 550px;
+}
+
+/* Special styles to use if we're converting subtitle links into header icons
*/
#firstHeading .mw-echo-special-header-link {
display: block;
height: 19px;
diff --git a/modules/special/ext.echo.special.js
b/modules/special/ext.echo.special.js
index 4432603..8903930 100644
--- a/modules/special/ext.echo.special.js
+++ b/modules/special/ext.echo.special.js
@@ -46,15 +46,10 @@
mw.echo.logInteraction( 'ui-prefs-click',
'archive' );
} );
- // Apply custom header styling for vector and monobook
skins
+ // Convert subtitle links into header icons for Vector
and Monobook skins
if ( skin === 'vector' || skin === 'monobook' ) {
- $( '#firstHeading' )
- .css( { 'max-width': '550px',
'margin-left': '50px' } );
- $( '#mw-echo-moreinfo-link' )
- .text( '' )
- .appendTo( '#firstHeading' );
- $( '#mw-echo-pref-link' )
- .text( '' )
+ $( '#mw-echo-moreinfo-link, #mw-echo-pref-link'
)
+ .empty()
.appendTo( '#firstHeading' );
$( '#contentSub' ).empty();
}
--
To view, visit https://gerrit.wikimedia.org/r/77569
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25eacb9c512fd6883a65df3af97608749b53b228
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
