jenkins-bot has submitted this change and it was merged.
Change subject: Fix issue in 7673a398
......................................................................
Fix issue in 7673a398
The update event passes in a transaction object, which was interpreted
as a config object and fragmented the cache. Explicitly wrap the
update() call in an event handler to make sure the config parameter is
undefined.
Change-Id: I641c68230b92d23626fb8b12aeab6a8904a35bcc
---
M modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
b/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
index fc207d5..a2eb107 100644
--- a/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
+++ b/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
@@ -22,7 +22,7 @@
this.$.attr( 'contenteditable', false );
// Events
- this.model.connect( this, { 'update': 'update' } );
+ this.model.connect( this, { 'update': 'onGeneratedContentNodeUpdate' }
);
// Initialization
this.update();
@@ -72,6 +72,13 @@
/* Methods */
/**
+ * Handler for the update event
+ */
+ve.ce.GeneratedContentNode.prototype.onGeneratedContentNodeUpdate = function
() {
+ this.update();
+};
+
+/**
* Rerender the contents of this node.
*
* @param {HTMLElement[]} domElements Array of DOM elements
--
To view, visit https://gerrit.wikimedia.org/r/79297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I641c68230b92d23626fb8b12aeab6a8904a35bcc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
