Werdna has submitted this change and it was merged.
Change subject: Use DerivativeRequest instead of FauxRequest
......................................................................
Use DerivativeRequest instead of FauxRequest
Using a FauxRequest causes issues in recording CheckUser data, as
well as when calling the API internally.
Change-Id: I7d5f42d3c465f262feb180fb60711872d9532c49
---
M api/ApiThreadAction.php
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Werdna: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/api/ApiThreadAction.php b/api/ApiThreadAction.php
index 50d4e99..67b4a84 100644
--- a/api/ApiThreadAction.php
+++ b/api/ApiThreadAction.php
@@ -298,9 +298,7 @@
if ( $user->isAllowed( 'bot' ) ) {
$requestData['bot'] = true;
}
-
- $editReq = new FauxRequest( $requestData, true );
- LqtView::fixFauxRequestSession( $editReq );
+ $editReq = new DerivativeRequest( $this->getRequest(),
$requestData, true );
$internalApi = new ApiMain( $editReq, true );
$internalApi->execute();
@@ -417,8 +415,7 @@
$requestData['bot'] = true;
}
- $editReq = new FauxRequest( $requestData, true );
- LqtView::fixFauxRequestSession( $editReq );
+ $editReq = new DerivativeRequest( $this->getRequest(),
$requestData, true );
$internalApi = new ApiMain( $editReq, true );
$internalApi->execute();
@@ -532,8 +529,7 @@
$requestData['bot'] = true;
}
- $editReq = new FauxRequest( $requestData, true );
- LqtView::fixFauxRequestSession( $editReq );
+ $editReq = new DerivativeRequest( $this->getRequest(),
$requestData, true );
$internalApi = new ApiMain( $editReq, true );
$internalApi->execute();
--
To view, visit https://gerrit.wikimedia.org/r/79181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d5f42d3c465f262feb180fb60711872d9532c49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
