Bsitu has uploaded a new change for review.
https://gerrit.wikimedia.org/r/80305
Change subject: Remove the fixed 600px width from html email
......................................................................
Remove the fixed 600px width from html email
This fixed width is making mobile-view not friendly, but some program like
outlook ignores max-width, it may look weird on wide screen
Change-Id: Ia4350669db2e81ee44d5b53d7cece6fcd8839e7a
---
M includes/EmailFormatter.php
1 file changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/05/80305/1
diff --git a/includes/EmailFormatter.php b/includes/EmailFormatter.php
index 21a7076..5d0cf77 100644
--- a/includes/EmailFormatter.php
+++ b/includes/EmailFormatter.php
@@ -323,19 +323,19 @@
<tr>
<td bgcolor="#E6E7E8"><center>
<br /><br />
- <table cellspacing="0" cellpadding="0" border="0" width="600">
+ <table cellspacing="0" cellpadding="0" border="0">
<tr>
<td bgcolor="#FFFFFF" width="35"> </td>
<td bgcolor="#FFFFFF" width="61"> </td>
- <td bgcolor="#FFFFFF" width="469"
style="line-height:40px;"> </td>
+ <td bgcolor="#FFFFFF" style="line-height:40px;
max-width: 469px;"> </td>
<td bgcolor="#FFFFFF" width="35"> </td>
</tr><tr>
- <td bgcolor="#FFFFFF" width="35"
rowspan="2"> </td>
- <td bgcolor="#FFFFFF" width="61" align="center"
valign="top" rowspan="2"><img src="%%emailIcon%%" alt="" height="30"
width="30"></td>
- <td bgcolor="#FFFFFF" width="469" align="left"
style="font-family:arial; font-size:13px; line-height:20px;
color:#6D6E70;">%%intro%%</td>
- <td bgcolor="#FFFFFF" width="35"
rowspan="2"> </td>
+ <td bgcolor="#FFFFFF" rowspan="2"> </td>
+ <td bgcolor="#FFFFFF" align="center"
valign="top" rowspan="2"><img src="%%emailIcon%%" alt="" height="30"
width="30"></td>
+ <td bgcolor="#FFFFFF" align="left"
style="font-family:arial; font-size:13px; line-height:20px;
color:#6D6E70;">%%intro%%</td>
+ <td bgcolor="#FFFFFF" rowspan="2"> </td>
</tr><tr>
- <td bgcolor="#FFFFFF" width="469" align="left"
style="font-family: arial; font-size:16px; line-height: 20px; font-weight:
600;">
+ <td bgcolor="#FFFFFF" align="left"
style="font-family: arial; font-size:16px; line-height: 20px; font-weight:
600;">
<table cellspacing="0" cellpadding="0"
border="0">
<tr>
<td bgcolor="#FFFFFF"
align="left" style="font-family: arial; padding-top: 8px; font-size:13px;
font-weight: bold; color: #58585B;">
@@ -352,18 +352,18 @@
</table>
</td>
</tr><tr>
- <td bgcolor="#FFFFFF" width="35"> </td>
- <td bgcolor="#FFFFFF" width="61"> </td>
- <td bgcolor="#FFFFFF" width="469"
style="line-height:40px;"> </td>
- <td bgcolor="#FFFFFF" width="35"> </td>
+ <td bgcolor="#FFFFFF"> </td>
+ <td bgcolor="#FFFFFF"> </td>
+ <td bgcolor="#FFFFFF"
style="line-height:40px;"> </td>
+ <td bgcolor="#FFFFFF"> </td>
</tr><tr>
- <td bgcolor="#F8F8F8" width="35"> </td>
- <td bgcolor="#F8F8F8" width="61"> </td>
- <td bgcolor="#F8F8F8" width="469" align="left"
style="font-family:arial; font-size:10px; line-height:13px; color:#6D6E70;
padding:10px 20px;"><br />
+ <td bgcolor="#F8F8F8"> </td>
+ <td bgcolor="#F8F8F8"> </td>
+ <td bgcolor="#F8F8F8" align="left"
style="font-family:arial; font-size:10px; line-height:13px; color:#6D6E70;
padding:10px 20px;"><br />
%%footer%%
<br /><br />
</td>
- <td bgcolor="#F8F8F8" width="35"> </td>
+ <td bgcolor="#F8F8F8"> </td>
</tr><tr>
<td colspan="4"> </td>
</tr>
@@ -472,21 +472,21 @@
<tr>
<td bgcolor="#E6E7E8"><center>
<br /><br />
- <table cellspacing="0" cellpadding="0" border="0" width="600">
+ <table cellspacing="0" cellpadding="0" border="0">
<tr>
<td bgcolor="#FFFFFF" width="35"> </td>
<td bgcolor="#FFFFFF" width="31"> </td>
- <td bgcolor="#FFFFFF" width="469"
style="line-height:40px;"> </td>
+ <td bgcolor="#FFFFFF" style="line-height:40px;
max-width: 469px;"> </td>
<td bgcolor="#FFFFFF" width="65"> </td>
</tr>
<tr>
- <td bgcolor="#FFFFFF" width="35"
rowspan="2"> </td>
- <td bgcolor="#FFFFFF" width="31"
rowspan="2"> </td>
- <td bgcolor="#FFFFFF" width="469"
align="center" style="font-family:arial; font-size:13px; line-height:20px;
color:#6D6E70; text-align: center;">%%intro%%</td>
- <td bgcolor="#FFFFFF" width="65"
rowspan="2"> </td>
+ <td bgcolor="#FFFFFF" rowspan="2"> </td>
+ <td bgcolor="#FFFFFF" rowspan="2"> </td>
+ <td bgcolor="#FFFFFF" align="center"
style="font-family:arial; font-size:13px; line-height:20px; color:#6D6E70;
text-align: center;">%%intro%%</td>
+ <td bgcolor="#FFFFFF" rowspan="2"> </td>
</tr>
<tr>
- <td bgcolor="#FFFFFF" width="469" align="left"
style="font-family: arial; font-size:16px; line-height: 20px; font-weight:
600;">
+ <td bgcolor="#FFFFFF" align="left"
style="font-family: arial; font-size:16px; line-height: 20px; font-weight:
600;">
<table cellspacing="0" cellpadding="0"
border="0" width="100%">
<tr>
<td bgcolor="#FFFFFF"
align="left" style="font-family: arial; font-size:13px; color: #58585B;
padding-top: 25px;">
@@ -498,25 +498,25 @@
</td>
</tr>
<tr>
- <td bgcolor="#FFFFFF" width="35"> </td>
- <td bgcolor="#FFFFFF" width="31"> </td>
- <td bgcolor="#FFFFFF" width="469"
style="line-height:60px;" align="center">%%action%%</td>
- <td bgcolor="#FFFFFF" width="65"> </td>
+ <td bgcolor="#FFFFFF"> </td>
+ <td bgcolor="#FFFFFF"> </td>
+ <td bgcolor="#FFFFFF" style="line-height:60px;"
align="center">%%action%%</td>
+ <td bgcolor="#FFFFFF"> </td>
</tr>
<tr>
- <td bgcolor="#FFFFFF" width="35"> </td>
- <td bgcolor="#FFFFFF" width="31"> </td>
- <td bgcolor="#FFFFFF" width="469"
style="line-height:40px;"> </td>
- <td bgcolor="#FFFFFF" width="65"> </td>
+ <td bgcolor="#FFFFFF"> </td>
+ <td bgcolor="#FFFFFF"> </td>
+ <td bgcolor="#FFFFFF"
style="line-height:40px;"> </td>
+ <td bgcolor="#FFFFFF"> </td>
</tr>
<tr>
- <td bgcolor="#F8F8F8" width="35"> </td>
- <td bgcolor="#F8F8F8" width="31"> </td>
- <td bgcolor="#F8F8F8" width="469" align="left"
style="font-family:arial; font-size:10px; line-height:13px; color:#6D6E70;
padding: 10px 20px;"><br />
+ <td bgcolor="#F8F8F8"> </td>
+ <td bgcolor="#F8F8F8"> </td>
+ <td bgcolor="#F8F8F8" align="left"
style="font-family:arial; font-size:10px; line-height:13px; color:#6D6E70;
padding: 10px 20px;"><br />
%%footer%%
<br /><br />
</td>
- <td bgcolor="#F8F8F8" width="65"> </td>
+ <td bgcolor="#F8F8F8"> </td>
</tr>
<tr>
<td colspan="4"> </td>
--
To view, visit https://gerrit.wikimedia.org/r/80305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4350669db2e81ee44d5b53d7cece6fcd8839e7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
