jenkins-bot has submitted this change and it was merged.
Change subject: Bug 53146: Percent-encode fragment identifiers too
......................................................................
Bug 53146: Percent-encode fragment identifiers too
We were only encoding the title part of a title URI. Also encode the fragment
id part.
Change-Id: I96d3679f027de620ef4891c8519934de4f701b7f
---
M js/lib/mediawiki.Util.js
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.Util.js b/js/lib/mediawiki.Util.js
index c41eec5..932187c 100644
--- a/js/lib/mediawiki.Util.js
+++ b/js/lib/mediawiki.Util.js
@@ -707,16 +707,19 @@
sanitizeTitleURI: function ( title ) {
var bits = title.split('#'),
- anchor = null;
+ anchor = null,
+ sanitize = function(s) {
+ return s.replace( /[%? \[\]#|]/g, function ( m
) {
+ return encodeURIComponent( m );
+ } );
+ };
if ( bits.length > 1 ) {
anchor = bits[bits.length - 1];
title = title.substring(0, title.length - anchor.length
- 1);
}
- title = title.replace( /[%? \[\]#|]/g, function ( m ) {
- return encodeURIComponent( m );
- } );
+ title = sanitize(title);
if ( anchor !== null ) {
- title += '#' + anchor;
+ title += '#' + sanitize(anchor);
}
return title;
},
--
To view, visit https://gerrit.wikimedia.org/r/80318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96d3679f027de620ef4891c8519934de4f701b7f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
