jenkins-bot has submitted this change and it was merged.
Change subject: Don't mask token on input
......................................................................
Don't mask token on input
Tokens are one time passwords. There's no strong reason to mask
them and listing it as a password field screws up many password
managers.
Change-Id: Iaf5446d80ec61ddec2403554b527781ab26493b3
---
M OATHUser.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/OATHUser.php b/OATHUser.php
index 7a6bfe6..dc8f665 100644
--- a/OATHUser.php
+++ b/OATHUser.php
@@ -289,8 +289,8 @@
$input = '<div><label for="wpOATHToken">'
. wfMsgHtml( 'oathauth-token' )
. '</label>'
- . Html::input( 'wpOATHToken', null, 'password', array(
- 'class' => 'loginPassword', 'id' =>
'wpOATHToken', 'tabindex' => '3', 'size' => '20'
+ . Html::input( 'wpOATHToken', null, 'text', array(
+ 'class' => 'loginText', 'id' => 'wpOATHToken',
'tabindex' => '3', 'size' => '20'
) ) . '</div>';
$template->set( 'extrafields', $input );
--
To view, visit https://gerrit.wikimedia.org/r/76124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf5446d80ec61ddec2403554b527781ab26493b3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/OATHAuth
Gerrit-Branch: master
Gerrit-Owner: Ryan Lane <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
