jenkins-bot has submitted this change and it was merged.
Change subject: htmlform multiselect chosen: Replace lists
......................................................................
htmlform multiselect chosen: Replace lists
Rather than appending a new checkbox list and removing the old one,
replace the old list with the new one, to preserve ordering.
Change-Id: Idd77455bdbaf423e7a51cf3789460d1980f78922
---
M resources/mediawiki/mediawiki.htmlform.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.htmlform.js
b/resources/mediawiki/mediawiki.htmlform.js
index 8e764e1..de06859 100644
--- a/resources/mediawiki/mediawiki.htmlform.js
+++ b/resources/mediawiki/mediawiki.htmlform.js
@@ -103,8 +103,7 @@
$fieldLabelText.text( $oldContainer.find( '.mw-label label'
).text() );
$fieldLabel.append( $fieldLabelText );
$container.prepend( $fieldLabel );
- $oldContainer.parent().append( $container );
- $oldContainer.remove();
+ $oldContainer.replaceWith( $container );
return $container;
}
--
To view, visit https://gerrit.wikimedia.org/r/78214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd77455bdbaf423e7a51cf3789460d1980f78922
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ryan Lane <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
