Rfaulk has submitted this change and it was merged.
Change subject: mv - aggregator constants to aggregator module.
......................................................................
mv - aggregator constants to aggregator module.
Change-Id: Iee17c76d00fb6e83cbbcfe2081eb986a06e35f1f
---
M user_metrics/etl/aggregator.py
M user_metrics/metrics/user_metric.py
2 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/etl/aggregator.py b/user_metrics/etl/aggregator.py
index 7a82e63..50e3a92 100644
--- a/user_metrics/etl/aggregator.py
+++ b/user_metrics/etl/aggregator.py
@@ -64,6 +64,21 @@
# Class for storing aggregate data
aggregate_data_class = namedtuple("AggregateData", "header data")
+# Define aggregator processing methods, method attributes, and namedtuple
+# class for packaging aggregate data
+
+# Respectively:
+#
+# 1. flag attribute for a type of metric aggregation methods
+# 2. header attribute for a type of metric aggregation methods
+# 3. name attribute for a type of metric aggregation methods
+# 4. keyword arg attribute for a type of metric aggregation methods
+# TODO - move these to the module dedicated for aggregation processing
+METRIC_AGG_METHOD_FLAG = 'metric_agg_flag'
+METRIC_AGG_METHOD_HEAD = 'metric_agg_head'
+METRIC_AGG_METHOD_NAME = 'metric_agg_name'
+METRIC_AGG_METHOD_KWARGS = 'metric_agg_kwargs'
+
def aggregator(agg_method, metric, data_header):
""" Method for wrapping and executing aggregated data """
diff --git a/user_metrics/metrics/user_metric.py
b/user_metrics/metrics/user_metric.py
index 813cff5..67df6b1 100644
--- a/user_metrics/metrics/user_metric.py
+++ b/user_metrics/metrics/user_metric.py
@@ -70,21 +70,6 @@
return wrapper
-# Define aggregator processing methods, method attributes, and namedtuple
-# class for packaging aggregate data
-
-# Respectively:
-#
-# 1. flag attribute for a type of metric aggregation methods
-# 2. header attribute for a type of metric aggregation methods
-# 3. name attribute for a type of metric aggregation methods
-# 4. keyword arg attribute for a type of metric aggregation methods
-# TODO - move these to the module dedicated for aggregation processing
-METRIC_AGG_METHOD_FLAG = 'metric_agg_flag'
-METRIC_AGG_METHOD_HEAD = 'metric_agg_head'
-METRIC_AGG_METHOD_NAME = 'metric_agg_name'
-METRIC_AGG_METHOD_KWARGS = 'metric_agg_kwargs'
-
def log_pool_worker_start(metric_name, worker_name, data, args):
"""
--
To view, visit https://gerrit.wikimedia.org/r/80530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee17c76d00fb6e83cbbcfe2081eb986a06e35f1f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
