jenkins-bot has submitted this change and it was merged.
Change subject: Don't try to insert perfstats if none given by client and no
callback.
......................................................................
Don't try to insert perfstats if none given by client and no callback.
Change-Id: I33a7b691b6c7e56d8f807ecc69085b7fd60410dd
---
M js/tests/server/server.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
GWicke: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/tests/server/server.js b/js/tests/server/server.js
index 1f9dad7..68f2199 100755
--- a/js/tests/server/server.js
+++ b/js/tests/server/server.js
@@ -480,11 +480,12 @@
};
var insertPerfStats = function( db, pageId, commitHash, perfstats, cb ) {
- // If empty, just go along
+ // If empty, just return
if ( !perfstats || perfstats.length === 0 ) {
if ( cb ) {
return cb( null, null );
}
+ return;
}
// Build the query to insert all the results in one go:
var dbStmt = dbInsertPerfStatsStart;
--
To view, visit https://gerrit.wikimedia.org/r/80580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33a7b691b6c7e56d8f807ecc69085b7fd60410dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: rt_testing
Gerrit-Owner: Marcoil <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
