Mollywhite has uploaded a new change for review.
https://gerrit.wikimedia.org/r/80691
Change subject: Bug 53288: Use more descriptive link titles for read/edit in
dropdowns
......................................................................
Bug 53288: Use more descriptive link titles for read/edit in dropdowns
The read/edit buttons in the metadata and chapterlist dropdowns
were lacking 'title' properties, which meant that there was no
real description of what they did.
Bug: 53288
Change-Id: I847e23f8765cec6e6f7c7982508586d20a6c7c64
---
M BookManagerv2.hooks.php
M BookManagerv2.i18n.php
2 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BookManagerv2
refs/changes/91/80691/1
diff --git a/BookManagerv2.hooks.php b/BookManagerv2.hooks.php
index 937ab60..be78f3f 100644
--- a/BookManagerv2.hooks.php
+++ b/BookManagerv2.hooks.php
@@ -268,14 +268,19 @@
'class' => 'mw-bookmanagerv2-link-bracket'
), '[' )
. Linker::link( $jsonPageTitle,
- wfMessage( 'bookmanagerv2-read' )->escaped()
+ wfMessage( 'bookmanagerv2-read' )->escaped(),
+ array( 'title' => wfMessage(
+ 'bookmanagerv2-read-json-block'
)->escaped() ),
+ array(),
+ array()
)
. Html::element( 'span', array(
'class' => 'mw-bookmanagerv2-link-divider'
), '|' )
. Linker::link( $jsonPageTitle,
wfMessage( 'editlink' )->escaped(),
- array(),
+ array( 'title' => wfMessage(
+ 'bookmanagerv2-edit-json-block'
)->escaped() ),
array( 'action' => 'edit' ),
array()
)
diff --git a/BookManagerv2.i18n.php b/BookManagerv2.i18n.php
index 4d5d20d..f273b6b 100644
--- a/BookManagerv2.i18n.php
+++ b/BookManagerv2.i18n.php
@@ -42,6 +42,8 @@
'bookmanagerv2-isbn' => 'ISBN: $1',
'bookmanagerv2-lccn' => 'LCCN: $1',
'bookmanagerv2-oclc' => 'OCLC: $1',
+ 'bookmanagerv2-read-json-block' => 'View the metadata and chapter list
for this work',
+ 'bookmanagerv2-edit-json-block' => 'Edit the metadata and chapter list
for this work',
'bookmanagerv2-metadata-heading' => 'Metadata',
'bookmanagerv2-sections-heading' => 'Sections',
'bookmanagerv2-move-alt' => 'Move this section',
@@ -187,6 +189,8 @@
See screenshot for an example of this dropdown.
[[File:BookManagerv2 navigation bar metadata dropdown.png]]',
+ 'bookmanagerv2-read-json-block' => 'Title for a link to explain that
clicking the \'read\' button will allow them to view the metadata and chapter
list for this work',
+ 'bookmanagerv2-edit-json-block' => 'Title for a link to explain that
clicking the \'edit\' button will allow them to edit the metadata and chapter
list for this work',
'bookmanagerv2-metadata-heading' => 'Heading for the collapsible
section of the JSON editor that holds the metadata (everything but the sections
information).
{{Identical|Metadata}}',
'bookmanagerv2-sections-heading' => 'Heading for the collapsible
section of the JSON editor that holds information on the sections of the book.
--
To view, visit https://gerrit.wikimedia.org/r/80691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I847e23f8765cec6e6f7c7982508586d20a6c7c64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BookManagerv2
Gerrit-Branch: master
Gerrit-Owner: Mollywhite <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
