Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/80795
Change subject: Improve snak testToArrayRoundtrip test
......................................................................
Improve snak testToArrayRoundtrip test
The ->equals() method basically justchecks
to see thet the classtype is correct and
the hashes are the same. Having these checks
in the test allows failure output to be more
usefull
This will naturally not pass unitl the issue is
fixed in Change: Ic66442813528bb30
Change-Id: Idaa7bc41f1aee70b8e2897fdda4de73ea353a520
---
M tests/phpunit/Snak/SnakTest.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDataModel
refs/changes/95/80795/1
diff --git a/tests/phpunit/Snak/SnakTest.php b/tests/phpunit/Snak/SnakTest.php
index e8656bf..73c95f6 100644
--- a/tests/phpunit/Snak/SnakTest.php
+++ b/tests/phpunit/Snak/SnakTest.php
@@ -132,6 +132,7 @@
$copy = \Wikibase\SnakObject::newFromArray( $data );
$this->assertInstanceOf( '\Wikibase\Snak', $copy,
'newFromArray should return object implementing Snak' );
+ $this->assertEquals( $snak->getHash(),
$copy->getHash(), 'newFromArray should return object with same Hash used
previously' );
$this->assertTrue( $snak->equals( $copy ), 'getArray
newFromArray roundtrip should work' );
}
--
To view, visit https://gerrit.wikimedia.org/r/80795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idaa7bc41f1aee70b8e2897fdda4de73ea353a520
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
