Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/80797
Change subject: Catch div zero error in ItemByTitleHelper
......................................................................
Catch div zero error in ItemByTitleHelper
Bug: 53037
Change-Id: Ib04b5dd57f2e96d21e7a0af47a18be0a365d097f
---
M repo/includes/api/ItemByTitleHelper.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/97/80797/1
diff --git a/repo/includes/api/ItemByTitleHelper.php
b/repo/includes/api/ItemByTitleHelper.php
index f136c78..9c23e55 100644
--- a/repo/includes/api/ItemByTitleHelper.php
+++ b/repo/includes/api/ItemByTitleHelper.php
@@ -88,6 +88,11 @@
);
}
+ // For cases when we have 0 sites we get a div0 error below.
Instead we should die gracefully
+ if( $numSites === 0 ){
+ $this->apiBase->dieUsage( 'No valid
sites','params-illegal' );
+ }
+
$idxSites = 0;
$idxTitles = 0;
--
To view, visit https://gerrit.wikimedia.org/r/80797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib04b5dd57f2e96d21e7a0af47a18be0a365d097f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
