jenkins-bot has submitted this change and it was merged.
Change subject: Use PHP_SAPI instead of php_sapi_name()
......................................................................
Use PHP_SAPI instead of php_sapi_name()
'Furthermore, PHP_SAPI rhymes with "happy", whereas "php_sapi_name"
rhymes with "lame". QED, etc.' - ori-l
Bug: 37957
Change-Id: I87a4fca72cac0d58807faf00eb12c9db07653e64
---
M cpp/php/parsoid.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/cpp/php/parsoid.php b/cpp/php/parsoid.php
index d23eef8..5896e5d 100644
--- a/cpp/php/parsoid.php
+++ b/cpp/php/parsoid.php
@@ -1,5 +1,5 @@
<?php
-$br = (php_sapi_name() == "cli")? "":"<br>";
+$br = (PHP_SAPI == "cli")? "":"<br>";
if(!extension_loaded('parsoid')) {
dl('parsoid.' . PHP_SHLIB_SUFFIX);
--
To view, visit https://gerrit.wikimedia.org/r/80866
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87a4fca72cac0d58807faf00eb12c9db07653e64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
