jenkins-bot has submitted this change and it was merged.
Change subject: Special:PagesWithProp: Use Language#formatSize
......................................................................
Special:PagesWithProp: Use Language#formatSize
Followup to Ib2db241a.
Change-Id: I138ecaf20feac162a554591332e5c4d1e3234768
---
M includes/specials/SpecialPagesWithProp.php
M languages/messages/MessagesEn.php
M languages/messages/MessagesQqq.php
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Parent5446: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialPagesWithProp.php
b/includes/specials/SpecialPagesWithProp.php
index 199c5cd..1c77a0c 100644
--- a/includes/specials/SpecialPagesWithProp.php
+++ b/includes/specials/SpecialPagesWithProp.php
@@ -136,7 +136,7 @@
if ( $isBinary || $isTooLong ) {
$message = $this
->msg( $isBinary ?
'pageswithprop-prophidden-binary' : 'pageswithprop-prophidden-long' )
- ->numParams( round( $valueLength /
1024, 2 ) );
+ ->params(
$this->getLanguage()->formatSize( $valueLength ) );
$propValue = Html::element( 'span', array(
'class' => 'prop-value-hidden' ), $message->text() );
} else {
diff --git a/languages/messages/MessagesEn.php
b/languages/messages/MessagesEn.php
index 67fe889..b29493e 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2676,8 +2676,8 @@
'pageswithprop-text' => 'This page lists pages that use a
particular page property.',
'pageswithprop-prop' => 'Property name:',
'pageswithprop-submit' => 'Go',
-'pageswithprop-prophidden-long' => 'long text property value hidden ($1
kilobytes)',
-'pageswithprop-prophidden-binary' => 'binary property value hidden ($1
kilobytes)',
+'pageswithprop-prophidden-long' => 'long text property value hidden ($1)',
+'pageswithprop-prophidden-binary' => 'binary property value hidden ($1)',
'doubleredirects' => 'Double redirects',
'doubleredirects-summary' => '', # do not translate or duplicate
this message to other languages
diff --git a/languages/messages/MessagesQqq.php
b/languages/messages/MessagesQqq.php
index 02938d6..0b6bff2 100644
--- a/languages/messages/MessagesQqq.php
+++ b/languages/messages/MessagesQqq.php
@@ -4425,13 +4425,13 @@
'pageswithprop-prophidden-long' => 'Information shown on
[[Special:PagesWithProp]] when property value is longer than 1 kilobyte.
Parameters:
-* $1 - size of property value in kilobytes
+* $1 - size of property value, formatted
See also:
* {{msg-mw|pageswithprop-prophidden-binary}}',
'pageswithprop-prophidden-binary' => 'Information shown on
[[Special:PagesWithProp]] when property value contains binary data.
Parameters:
-* $1 - size of property value in kilobytes
+* $1 - size of property value, formatted
See also:
* {{msg-mw|pageswithprop-prophidden-long}}',
--
To view, visit https://gerrit.wikimedia.org/r/79468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I138ecaf20feac162a554591332e5c4d1e3234768
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
