TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/80872
Change subject: Accessibility: Add aria-sort to tablesorter
......................................................................
Accessibility: Add aria-sort to tablesorter
Note, aria-sort is not supported in VO, and in JAWS it seems aria-sort
has a check on role === 'columnheader' instead of element.hasRole(
'columnheader' ). sigh....
Change-Id: I2c414ed0b88bafc04989152acae8298d2130d393
---
M resources/jquery/jquery.tablesorter.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/72/80872/1
diff --git a/resources/jquery/jquery.tablesorter.js
b/resources/jquery/jquery.tablesorter.js
index b71ef83..29e8cdf 100644
--- a/resources/jquery/jquery.tablesorter.js
+++ b/resources/jquery/jquery.tablesorter.js
@@ -406,12 +406,16 @@
function setHeadersCss( table, $headers, list, css, msg, columnToHeader
) {
// Remove all header information and reset titles to default
message
- $headers.removeClass( css[0] ).removeClass( css[1] ).attr(
'title', msg[1] );
+ $headers.removeClass( css[0] ).removeClass( css[1] ).attr(
'title', msg[1] ).removeAttr( 'aria-sort' );
for ( var i = 0; i < list.length; i++ ) {
$headers.eq( columnToHeader[ list[i][0] ] )
.addClass( css[ list[i][1] ] )
- .attr( 'title', msg[ list[i][1] ] );
+ .attr( {
+ title: msg[ list[i][1] ],
+ // This is not fully correct, but aria
doesn't support our method of secondary keys
+ 'aria-sort': ( i == 0 && list[i][1] ===
0 ? 'ascending' : 'descending' )
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/80872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c414ed0b88bafc04989152acae8298d2130d393
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
