jenkins-bot has submitted this change and it was merged.
Change subject: Make methods that should be implemented abstract
......................................................................
Make methods that should be implemented abstract
Change-Id: I1ccb49e6dd4a9df46d9dc496af6ce204fe3bb01e
---
M DataValues/tests/phpunit/DataValueTest.php
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DataValues/tests/phpunit/DataValueTest.php
b/DataValues/tests/phpunit/DataValueTest.php
index f2e1fc0..ea75531 100644
--- a/DataValues/tests/phpunit/DataValueTest.php
+++ b/DataValues/tests/phpunit/DataValueTest.php
@@ -26,13 +26,9 @@
*/
public abstract function getClass();
- public function validConstructorArgumentsProvider() {
- return array();
- }
+ public abstract function validConstructorArgumentsProvider();
- public function invalidConstructorArgumentsProvider() {
- return array();
- }
+ public abstract function invalidConstructorArgumentsProvider();
/**
* Creates and returns a new instance of the concrete class.
--
To view, visit https://gerrit.wikimedia.org/r/80199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ccb49e6dd4a9df46d9dc496af6ce204fe3bb01e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
