jenkins-bot has submitted this change and it was merged.
Change subject: Selenium: fix waitForApi
......................................................................
Selenium: fix waitForApi
Change-Id: Id55564241ec4b5751946ce128ed9854026d0d028
---
M selenium_cuc/features/support/modules/entity_module.rb
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/selenium_cuc/features/support/modules/entity_module.rb
b/selenium_cuc/features/support/modules/entity_module.rb
index 78f3626..0997a7b 100644
--- a/selenium_cuc/features/support/modules/entity_module.rb
+++ b/selenium_cuc/features/support/modules/entity_module.rb
@@ -64,8 +64,6 @@
# ***** METHODS *****
def wait_for_api_callback
#TODO: workaround for weird error randomly claiming that
apiCallWaitingMessage-element is not attached to the DOM anymore
- sleep 1
- return
wait_until do
apiCallWaitingMessage? == false
end
--
To view, visit https://gerrit.wikimedia.org/r/79972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id55564241ec4b5751946ce128ed9854026d0d028
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
