MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/81147
Change subject: Throw errors if required fields missing
......................................................................
Throw errors if required fields missing
To make it easier to find problems for developers.
Change-Id: I2671b50ff4731d9b8040c563b7b808ea15b964f7
---
M BetaFeaturesHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures
refs/changes/47/81147/1
diff --git a/BetaFeaturesHooks.php b/BetaFeaturesHooks.php
index 4f4de72..8b3c42d 100644
--- a/BetaFeaturesHooks.php
+++ b/BetaFeaturesHooks.php
@@ -188,7 +188,7 @@
// we got from the
GetBetaFeaturePreferences hook.
// Don't add this feature to the form.
$complete = false;
- break;
+ throw new Exception( 'The field ' .
$field . ' was missing from the beta feature ' . $key . '.' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/81147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2671b50ff4731d9b8040c563b7b808ea15b964f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits