Arlolra has uploaded a new change for review.
https://gerrit.wikimedia.org/r/81166
Change subject: Fix bug in foster parented content detection
......................................................................
Fix bug in foster parented content detection
Introduced in 7bd2df748b013d17971427e953b23a53356a982c.
nextSibling was null for text nodes after wrapping in span.
Test case presented was,
{| !! width=200
| 1
|}
{|
| 2
|}
Change-Id: Ie61ddc5f78e9b62af9441a965e8e66e4b19789d4
---
M js/lib/dom.markFosteredContent.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/66/81166/1
diff --git a/js/lib/dom.markFosteredContent.js
b/js/lib/dom.markFosteredContent.js
index 55676ad..ecf2a49 100644
--- a/js/lib/dom.markFosteredContent.js
+++ b/js/lib/dom.markFosteredContent.js
@@ -24,13 +24,14 @@
) ) {
if ( DU.isElt( sibling ) ) {
sibling.data.parsoid.fostered = true;
+ sibling = sibling.nextSibling;
} else {
span =
sibling.ownerDocument.createElement( "span" );
span.data = { parsoid: { fostered: true
} };
sibling.parentNode.insertBefore( span,
sibling );
span.appendChild( sibling );
+ sibling = span.nextSibling;
}
- sibling = sibling.nextSibling;
}
DU.deleteNode( c );
}
--
To view, visit https://gerrit.wikimedia.org/r/81166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie61ddc5f78e9b62af9441a965e8e66e4b19789d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
