Subramanya Sastry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/81177


Change subject: Fix for html2wt crasher: Add TSR info to mw:EmptyLine meta-token
......................................................................

Fix for html2wt crasher: Add TSR info to mw:EmptyLine meta-token

* Template arg escaping relies on tokenizing adding TSR on all
  tokens.  Fixes RT errors on en:Avalon,_Pennsylvania found in
  RT tasting.

* Sample test case extracted from page:

{{Geobox|Settlement
<!-- *** Name section *** -->
| name = Avalon
}}

Change-Id: I6b8acee9af045798a927ebf66ea63209a60393f9
---
M js/lib/pegTokenizer.pegjs.txt
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/77/81177/1

diff --git a/js/lib/pegTokenizer.pegjs.txt b/js/lib/pegTokenizer.pegjs.txt
index 349fbef..7899994 100644
--- a/js/lib/pegTokenizer.pegjs.txt
+++ b/js/lib/pegTokenizer.pegjs.txt
@@ -2342,11 +2342,12 @@
     }
 
 empty_line_with_comments
-  = sp:sol_prefix c:(space* comment (space / comment)* newline)+ {
+  = sp:sol_prefix p:({return pos;}) c:(space* comment (space / comment)* 
newline)+ {
         return [
             sp,
             new SelfclosingTagTk("meta", [new KV('typeof', 'mw:EmptyLine')], {
-                tokens: flattenIfArray(c)
+                tokens: flattenIfArray(c),
+                tsr: [p, pos]
             })
         ];
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/81177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b8acee9af045798a927ebf66ea63209a60393f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to