Rfaulk has submitted this change and it was merged.

Change subject: mod/add - flesh out Aggregator class / Create AggregatorStatOp 
subclass.
......................................................................


mod/add - flesh out Aggregator class / Create AggregatorStatOp subclass.

Change-Id: I048c77d8b07df9b948598891e7228d1988cc8016
---
M user_metrics/etl/aggregator.py
1 file changed, 24 insertions(+), 4 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved



diff --git a/user_metrics/etl/aggregator.py b/user_metrics/etl/aggregator.py
index 9a8c175..314e69d 100644
--- a/user_metrics/etl/aggregator.py
+++ b/user_metrics/etl/aggregator.py
@@ -347,18 +347,20 @@
         Initialize the aggregator method
         """
         self._method = method
+        self._header = ['result']
 
     def data_etl(self, data):
         """
-        Handle
+        Handles data modification prior to aggregation
         """
         return data
 
     def post_process(self, data):
         """
-        Define
+        Handles assigning aggregate values to relevant properties
+        after aggregation
         """
-        self._result =  data
+        self._result = data
 
     def run(self, data):
         """
@@ -369,5 +371,23 @@
             self.data_etl(data)))
         return self
 
+    @property
     def header(self):
-        return ['result']
+        return self._header
+
+
+class AggregatorStatOp(Aggregator):
+    """
+    This type handles basic statistical operations like mean, median, sum, etc.
+    """
+
+    def __init__(self, methods, field_prefixes, header):
+        super(AggregatorStatOp, self).__init__(methods)
+        self._header = header
+        self._field_prefixes = field_prefixes
+
+    def data_etl(self, data):
+        super(AggregatorStatOp, self).data_etl(data)
+
+    def post_process(self, data):
+        super(AggregatorStatOp, self).post_process(data)
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/81181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I048c77d8b07df9b948598891e7228d1988cc8016
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to