[MediaWiki-commits] [Gerrit] Improvements to ByPropertyListUnserializerTest - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/81554


Change subject: Improvements to ByPropertyListUnserializerTest
......................................................................

Improvements to ByPropertyListUnserializerTest

Change-Id: I491ec0397c9863f07d319011db3c4ca27e4b51cb
---
M lib/tests/phpunit/serializers/ByPropertyListUnserializerTest.php
1 file changed, 13 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/54/81554/1

diff --git a/lib/tests/phpunit/serializers/ByPropertyListUnserializerTest.php 
b/lib/tests/phpunit/serializers/ByPropertyListUnserializerTest.php
index 00d97d3..4d5c073 100644
--- a/lib/tests/phpunit/serializers/ByPropertyListUnserializerTest.php
+++ b/lib/tests/phpunit/serializers/ByPropertyListUnserializerTest.php
@@ -2,8 +2,13 @@
 
 namespace Wikibase\Lib\Test\Serializers;
 
+use Wikibase\DataModel\Entity\PropertyId;
 use Wikibase\Lib\Serializers\ByPropertyListUnserializer;
 use Wikibase\Lib\Serializers\SnakSerializer;
+use Wikibase\PropertyNoValueSnak;
+use Wikibase\PropertySomeValueSnak;
+use Wikibase\PropertyValueSnak;
+use Wikibase\SnakList;
 
 /**
  * @covers Wikibase\Lib\Serializers\ByPropertyListUnserializer
@@ -58,20 +63,20 @@
 
                $dataValue0 = new \DataValues\StringValue( 'ohi' );
 
-               $id42 = new \Wikibase\EntityId( 
\Wikibase\Property::ENTITY_TYPE, 42 );
-               $id2 = new \Wikibase\EntityId( \Wikibase\Property::ENTITY_TYPE, 
2 );
+               $id42 = new PropertyId( 'P42' );
+               $id2 = new PropertyId( 'P2' );
 
-               $snak0 = new \Wikibase\PropertyNoValueSnak( $id42 );
-               $snak1 = new \Wikibase\PropertySomeValueSnak( $id2 );
-               $snak2 = new \Wikibase\PropertyValueSnak( $id2, $dataValue0 );
+               $snak0 = new PropertyNoValueSnak( $id42 );
+               $snak1 = new PropertySomeValueSnak( $id2 );
+               $snak2 = new PropertyValueSnak( $id2, $dataValue0 );
 
-               $validArgs[] = new \Wikibase\SnakList( array( $snak0, $snak1, 
$snak2 ) );
+               $validArgs[] = new SnakList( array( $snak0, $snak1, $snak2 ) );
 
                $validArgs = $this->arrayWrap( $validArgs );
 
                $validArgs[] = array(
                        array(),
-                       new \Wikibase\SnakList(),
+                       new SnakList(),
                );
 
                $validArgs[] = array(
@@ -94,7 +99,7 @@
                                        ),
                                ),
                        ),
-                       new \Wikibase\SnakList( array( $snak0, $snak1, $snak2 ) 
),
+                       new SnakList( array( $snak0, $snak1, $snak2 ) ),
                );
 
                return $validArgs;

-- 
To view, visit https://gerrit.wikimedia.org/r/81554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I491ec0397c9863f07d319011db3c4ca27e4b51cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits