coren has submitted this change and it was merged.
Change subject: Drop 'country' from NavTiming graphs; rename to 'browser'
......................................................................
Drop 'country' from NavTiming graphs; rename to 'browser'
I'd like to start off simple, and splitting the data by country is more than I
can chew at the moment. Also group metrics under 'stats.timers.browser' rather
than 'stats.timers.navigation', for clarity. (I'll prune the old metrics from
Graphite.)
Change-Id: I9f3238adbae2711b7af2328e3fe3b7de6fb4f9f5
---
M files/graphite/modules/navtiming.py
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
coren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/files/graphite/modules/navtiming.py
b/files/graphite/modules/navtiming.py
index 987ad98..db187e2 100644
--- a/files/graphite/modules/navtiming.py
+++ b/files/graphite/modules/navtiming.py
@@ -42,10 +42,9 @@
continue
site = 'mobile' if 'mobileMode' in event else 'desktop'
- country = event.get('originCountry') or 'ZZ'
for metric in metrics:
value = event.get(metric)
- if value > 0:
- stat = 'navigation.%s.%s.%s:%s|ms' % (metric, site, country, value)
+ if value > 0 and value < 60000:
+ stat = 'browser.%s.%s:%s|ms' % (metric, site, value)
sock.sendto(stat.encode('utf-8'), addr)
--
To view, visit https://gerrit.wikimedia.org/r/81561
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f3238adbae2711b7af2328e3fe3b7de6fb4f9f5
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
