Akosiaris has submitted this change and it was merged.

Change subject: require nrpe package before collecting
......................................................................


require nrpe package before collecting

There was a race condition where collection of virtual resources defined
by nrpe::check and collected by nrpe class could happen before the
directory /etc/nagios/nrpe.d/ would be created. This directory is
created by package nagios-nrpe-server so we depend the collection on
this package.

Change-Id: I1c1d276b4bffb8cea787c5c6c403c0b6152e0216
---
M modules/nrpe/manifests/init.pp
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Akosiaris: Looks good to me, approved
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/modules/nrpe/manifests/init.pp b/modules/nrpe/manifests/init.pp
index 901ced4..ac0d60b 100644
--- a/modules/nrpe/manifests/init.pp
+++ b/modules/nrpe/manifests/init.pp
@@ -77,5 +77,7 @@
     }
 
     #Collect virtual nrpe checks
-    File <| tag == 'nrpe::check' |>
+    File <| tag == 'nrpe::check' |> {
+        require => Package['nagios-nrpe-server'],
+    }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/81676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c1d276b4bffb8cea787c5c6c403c0b6152e0216
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Akosiaris <[email protected]>
Gerrit-Reviewer: Akosiaris <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to