Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/81964
Change subject: Bug 52000 - Reusing new reference groups
......................................................................
Bug 52000 - Reusing new reference groups
The search index was only being built on initialization, rather than at the
time the list was being shown. By moving it to be built at the last minute the
index will be current each time the reference search is used.
Bug: 52000
Change-Id: Ib38b1b227edc3d61dc49fa58999358e7adf11b08
---
M modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/64/81964/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
index 8c7a2fc..15d8773 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
@@ -129,6 +129,7 @@
this.insertButton.$.hide();
this.selectButton.$.hide();
this.panels.showItem( this.searchPanel );
+ this.search.buildIndex();
this.search.getQuery().$input.focus().select();
} } );
this.backButton.connect( this, { 'click': function () {
@@ -141,7 +142,6 @@
this.search.connect( this, { 'select': 'onSearchSelect' } );
// Initialization
- this.search.buildIndex();
this.panels.addItems( [ this.editPanel, this.searchPanel ] );
this.editPanel.$.append( this.contentFieldset.$, this.optionsFieldset.$
);
this.optionsFieldset.$.append( this.referenceGroupLabel.$,
this.referenceGroupInput.$ );
--
To view, visit https://gerrit.wikimedia.org/r/81964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib38b1b227edc3d61dc49fa58999358e7adf11b08
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
