jenkins-bot has submitted this change and it was merged.
Change subject: Re-build reference search index so they can be used mid-edit
......................................................................
Re-build reference search index so they can be used mid-edit
The search index was only being built on initialization, rather than at
the time the list was being shown. By moving it to be built on open
the list will always be fresh. Also, just after building the index, we can
enable/disable the select existing button based on the number of
results.
Bug: 51689
Bug: 51848
Bug: 52000
Change-Id: Ib38b1b227edc3d61dc49fa58999358e7adf11b08
---
M modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
index 8c7a2fc..5a53e62 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
@@ -141,7 +141,6 @@
this.search.connect( this, { 'select': 'onSearchSelect' } );
// Initialization
- this.search.buildIndex();
this.panels.addItems( [ this.editPanel, this.searchPanel ] );
this.editPanel.$.append( this.contentFieldset.$, this.optionsFieldset.$
);
this.optionsFieldset.$.append( this.referenceGroupLabel.$,
this.referenceGroupInput.$ );
@@ -190,6 +189,8 @@
this.backButton.$.hide();
this.panels.showItem( this.editPanel );
this.useReference( ref );
+ this.search.buildIndex();
+ this.selectButton.setDisabled(
!this.search.getResults().getItems().length );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/81964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib38b1b227edc3d61dc49fa58999358e7adf11b08
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
