jenkins-bot has submitted this change and it was merged.

Change subject: Cleanup and add documentation for tags
......................................................................


Cleanup and add documentation for tags

* Fixed one scenario to work with the default setting
* Fixed one typo in scenario
* Removed unused tags
* Documented the tags currently in use

Change-Id: I14687782857daf79dcd497b934dff99fc45a3997
---
M tests/browser/features/font_selection.feature
M tests/browser/features/uls_accept_language.feature
M tests/browser/features/uls_settings_panel.feature
A tests/browser/tags.txt
4 files changed, 32 insertions(+), 6 deletions(-)

Approvals:
  KartikMistry: Checked; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/features/font_selection.feature 
b/tests/browser/features/font_selection.feature
index 621b6b9..c1a0899 100644
--- a/tests/browser/features/font_selection.feature
+++ b/tests/browser/features/font_selection.feature
@@ -1,4 +1,4 @@
-@reset-preferences-after @login @en.wikipedia.beta.wmflabs.org 
@commons.wikimedia.beta.wmflabs.org
+@login @reset-preferences-after @en.wikipedia.beta.wmflabs.org 
@commons.wikimedia.beta.wmflabs.org
 Feature: Font selection
 
   In order to have better using experience,
diff --git a/tests/browser/features/uls_accept_language.feature 
b/tests/browser/features/uls_accept_language.feature
index d061571..4df402b 100644
--- a/tests/browser/features/uls_accept_language.feature
+++ b/tests/browser/features/uls_accept_language.feature
@@ -1,4 +1,4 @@
-@ie6-bug  @ie7-bug  @ie8-bug  @ie9-bug @language @sandbox.translatewiki.net
+@language
 Feature: Universal Language Selector Accept-Language
 
   Scenario Outline: Accept-Language
diff --git a/tests/browser/features/uls_settings_panel.feature 
b/tests/browser/features/uls_settings_panel.feature
index abe3ee1..dc53b74 100644
--- a/tests/browser/features/uls_settings_panel.feature
+++ b/tests/browser/features/uls_settings_panel.feature
@@ -1,13 +1,13 @@
 @commons.wikimedia.beta.wmflabs.org @en.wikipedia.beta.wmflabs.org
 Feature: ULS settings panel
 
-  @login
+  @login @ime-default-on
   Scenario Outline: Input settings display
-    Givan I am <user status>
+    Given I am <user status>
       And I am on a page without interlanguage links
     When I open "Input" panel of language settings
-    Then I can enable input methods
-      And I can disable input methods
+    Then I can disable input methods
+      And I can enable input methods
 
   Examples:
     | user status |
diff --git a/tests/browser/tags.txt b/tests/browser/tags.txt
new file mode 100644
index 0000000..20d0698
--- /dev/null
+++ b/tests/browser/tags.txt
@@ -0,0 +1,26 @@
+This file contains the descriptions of the tags we use.
+
[email protected]
[email protected]
+  Test is run on this domain unless further excluded by other tags.
+
+@language
+  This tests needs support from Accept-Language header setting from the
+  webdriver.
+
+@ime-default-on
+  These tests expect input methods to be enabled by default.
+
+@login
+  This test logs in. You can filter these tests out if you don't have an
+  account available.
+
+@reset-preferences-after
+  This test changes user preferences and resets them at the end. In theory you
+  could use your normal user account if you skip these tests, but I would not
+  recommend doing that.
+
+@uls-in-personal-only
+@uls-in-sidebar-only
+  These tests will automatically be marked as skipped if ULS configuration is
+  not the one expected for the test.

-- 
To view, visit https://gerrit.wikimedia.org/r/82245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14687782857daf79dcd497b934dff99fc45a3997
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to