Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/82246
Change subject: Add badges check to getentities test
......................................................................
Add badges check to getentities test
Change-Id: I65586b42ebd8b9971d360fdedbcddd95271f876f
---
M repo/tests/phpunit/includes/api/GetEntitiesTest.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/46/82246/2
diff --git a/repo/tests/phpunit/includes/api/GetEntitiesTest.php
b/repo/tests/phpunit/includes/api/GetEntitiesTest.php
index dda5a18..80ae418 100644
--- a/repo/tests/phpunit/includes/api/GetEntitiesTest.php
+++ b/repo/tests/phpunit/includes/api/GetEntitiesTest.php
@@ -60,7 +60,7 @@
array( 'p' => array( 'sites' => 'dewiki', 'titles' => 'Berlin',
'normalize' => '' ), 'e' => array( 'count' => 1, 'normalized' => false ) ),
array( 'p' => array( 'sites' => 'dewiki', 'titles' => 'hoo',
'normalize' => '' ), 'e' => array( 'count' => 1, 'missing' => 1, 'normalized'
=> true ) ),
);
- protected static $goodProps = array( 'info', 'sitelinks', 'aliases',
'labels', 'descriptions', 'claims', 'datatype', 'labels|sitelinks/urls',
'info|aliases|labels|claims' );
+ protected static $goodProps = array( 'info', 'sitelinks', 'aliases',
'labels', 'descriptions', 'claims', 'datatype', 'sitelinks/badges',
'labels|sitelinks/urls', 'info|aliases|labels|claims|sitelinks/badges' );
protected static $goodLangs = array( 'de', 'zh', 'it|es|zh|ar',
'de|nn|no|en|en-gb|it|es|zh|ar' );
protected static $goodSorts = array( array( 'sort' => 'sitelinks',
'dir' => 'descending' ), array( 'sort' => 'sitelinks', 'dir' => 'ascending' ) );
protected static $goodFormats = array( 'json', 'php', 'wddx', 'xml',
'yaml', 'txt', 'dbg', 'dump' );
@@ -216,8 +216,8 @@
private function assertPropsSitelinksBadges( $entity, $expected ) {
$expected['props'][] = 'sitelinks';
foreach( $entity['sitelinks'] as $sitelink ){
- $this->assertArrayHasKey( 'badge', $sitelink );
- $this->assertNotEmpty( $sitelink['badge'] );
+ $this->assertArrayHasKey( 'badges', $sitelink );
+ $this->assertTrue( is_array( $sitelink['badges'] ) );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/82246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65586b42ebd8b9971d360fdedbcddd95271f876f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
