Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/82664
Change subject: jquery.suggestions: Add some comments
......................................................................
jquery.suggestions: Add some comments
Change-Id: I0706e1f847f8ebf3d48cbb40a88dd6f6d487d2e6
---
M resources/jquery/jquery.suggestions.js
1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/64/82664/1
diff --git a/resources/jquery/jquery.suggestions.js
b/resources/jquery/jquery.suggestions.js
index 93fba49..bf38769 100644
--- a/resources/jquery/jquery.suggestions.js
+++ b/resources/jquery/jquery.suggestions.js
@@ -379,8 +379,7 @@
preventDefault = false;
switch ( key ) {
- // Arrow down
- case 40:
+ case 40: // Arrow down
if ( wasVisible ) {
$.suggestions.highlight( context,
'next', true );
context.data.selectedWithMouse = false;
@@ -389,24 +388,21 @@
}
preventDefault = true;
break;
- // Arrow up
- case 38:
+ case 38: // Arrow up
if ( wasVisible ) {
$.suggestions.highlight( context,
'prev', true );
context.data.selectedWithMouse = false;
}
preventDefault = wasVisible;
break;
- // Escape
- case 27:
+ case 27: // Escape
context.data.$container.hide();
$.suggestions.restore( context );
$.suggestions.cancel( context );
context.data.$textbox.trigger( 'change' );
preventDefault = wasVisible;
break;
- // Enter
- case 13:
+ case 13: // Enter
context.data.$container.hide();
preventDefault = wasVisible;
selected = context.data.$container.find(
'.suggestions-result-current' );
@@ -585,13 +581,13 @@
switch ( context.data.keypressed ) {
// This preventDefault logic is
duplicated from
// $.suggestions.keypress(),
which sucks
- case 40:
+ case 40: // Arrow down
e.preventDefault();
e.stopImmediatePropagation();
break;
- case 38:
- case 27:
- case 13:
+ case 38: // Arrow up
+ case 27: // Escape
+ case 13: // Enter
if (
context.data.$container.is( ':visible' ) ) {
e.preventDefault();
e.stopImmediatePropagation();
--
To view, visit https://gerrit.wikimedia.org/r/82664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0706e1f847f8ebf3d48cbb40a88dd6f6d487d2e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
