Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/82787
Change subject: Fixup for insertMeta
......................................................................
Fixup for insertMeta
Change-Id: I252b55ead86accce4aa5b51ac03a49e8b5d591a6
---
M modules/ve/dm/ve.dm.Document.js
M modules/ve/dm/ve.dm.Transaction.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/87/82787/1
diff --git a/modules/ve/dm/ve.dm.Document.js b/modules/ve/dm/ve.dm.Document.js
index 216b30f..e8adbe2 100644
--- a/modules/ve/dm/ve.dm.Document.js
+++ b/modules/ve/dm/ve.dm.Document.js
@@ -342,7 +342,7 @@
* @param {number} offset Data offset to start at
* @param {number} remove Number of elements being removed
* @param {Array} insert Element data being inserted
- * @param {Array} [insertMeta] Metadata being inserted
+ * @param {Array} [insertMeta] Overwrite the metadata with this data, rather
than collapsing it
* @returns {Object|null} Metadata replace operation to keep data & metadata
in sync
*/
ve.dm.Document.prototype.getMetadataReplace = function ( offset, remove,
insert, insertMeta ) {
diff --git a/modules/ve/dm/ve.dm.Transaction.js
b/modules/ve/dm/ve.dm.Transaction.js
index b4fe275..024aeb6 100644
--- a/modules/ve/dm/ve.dm.Transaction.js
+++ b/modules/ve/dm/ve.dm.Transaction.js
@@ -877,7 +877,7 @@
* @param {number} offset Offset to start at
* @param {number} removeLength Number of data items to remove
* @param {Array} insert Data to insert
- * @param {Array} [insertMeta] Metadata to insert
+ * @param {Array} [insertMeta] Overwrite the metadata with this data, rather
than collapsing it
*/
ve.dm.Transaction.prototype.pushReplace = function ( doc, offset,
removeLength, insert, insertMeta ) {
if ( removeLength === 0 && insert.length === 0 ) {
--
To view, visit https://gerrit.wikimedia.org/r/82787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I252b55ead86accce4aa5b51ac03a49e8b5d591a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
