Daniel Werner has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/82838


Change subject: Remove unnecessary call to EntityContentFactory::singleton() in 
EntityView
......................................................................

Remove unnecessary call to EntityContentFactory::singleton() in EntityView

Change-Id: Ia4109fa7a279d549949afdb9a8c5e50cfa4baad5
---
M repo/includes/EntityView.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/38/82838/1

diff --git a/repo/includes/EntityView.php b/repo/includes/EntityView.php
index ce736d0..fcc9953 100644
--- a/repo/includes/EntityView.php
+++ b/repo/includes/EntityView.php
@@ -270,8 +270,6 @@
                $refFinder = new ReferencedEntitiesFinder();
                $usedEntityIds = $refFinder->findSnakLinks( $allSnaks );
 
-               $contentFactory = EntityContentFactory::singleton();
-
                foreach ( $usedEntityIds as $entityId ) {
                        $pout->addLink( 
$this->entityTitleLookup->getTitleForId( $entityId ) );
                }
@@ -290,7 +288,7 @@
                }
 
                //@todo: record sitelinks as iwlinks
-               //@todo: record CommnsMedia values as imagelinks
+               //@todo: record CommonsMedia values as imagelinks
 
                // make css available for JavaScript-less browsers
                $pout->addModuleStyles( array(

-- 
To view, visit https://gerrit.wikimedia.org/r/82838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4109fa7a279d549949afdb9a8c5e50cfa4baad5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to