Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove unnecessary call to EntityContentFactory::singleton() in
EntityView
......................................................................
Remove unnecessary call to EntityContentFactory::singleton() in EntityView
Change-Id: Ia4109fa7a279d549949afdb9a8c5e50cfa4baad5
---
M repo/includes/EntityView.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/EntityView.php b/repo/includes/EntityView.php
index ce736d0..fcc9953 100644
--- a/repo/includes/EntityView.php
+++ b/repo/includes/EntityView.php
@@ -270,8 +270,6 @@
$refFinder = new ReferencedEntitiesFinder();
$usedEntityIds = $refFinder->findSnakLinks( $allSnaks );
- $contentFactory = EntityContentFactory::singleton();
-
foreach ( $usedEntityIds as $entityId ) {
$pout->addLink(
$this->entityTitleLookup->getTitleForId( $entityId ) );
}
@@ -290,7 +288,7 @@
}
//@todo: record sitelinks as iwlinks
- //@todo: record CommnsMedia values as imagelinks
+ //@todo: record CommonsMedia values as imagelinks
// make css available for JavaScript-less browsers
$pout->addModuleStyles( array(
--
To view, visit https://gerrit.wikimedia.org/r/82838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4109fa7a279d549949afdb9a8c5e50cfa4baad5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
