jenkins-bot has submitted this change and it was merged.

Change subject: Check return code of git pull to avoid false positives
......................................................................


Check return code of git pull to avoid false positives

Change-Id: I20729fd5ff1093e8729cdd108e9010ae133c9b1f
---
M bin/wikiupdate-repo
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/bin/wikiupdate-repo b/bin/wikiupdate-repo
index e729186..20fca72 100755
--- a/bin/wikiupdate-repo
+++ b/bin/wikiupdate-repo
@@ -2,8 +2,9 @@
 
 cd $1
 OUTPUT=$(git pull --quiet --rebase 2>&1 >&-)
+CODE=$?
 
-if [ "$OUTPUT" != "" ]; then
+if [ $CODE -ne 0 ]; then
        printf "\033[31m%s failed to update\033[0m\n" "$1";
        echo $OUTPUT;
 fi

-- 
To view, visit https://gerrit.wikimedia.org/r/82807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I20729fd5ff1093e8729cdd108e9010ae133c9b1f
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to