jenkins-bot has submitted this change and it was merged.
Change subject: Clean up use of ->text() with HTML
......................................................................
Clean up use of ->text() with HTML
While these aren't much of a concern in practice, unless ->text() is
specifically needed it's better to use ->escaped() for sanity's sake.
Change-Id: I6eeaa7aa6a968514ab40fa485141b666505f6b07
---
M CentralAuthHooks.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
CSteipp: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralAuthHooks.php b/CentralAuthHooks.php
index 6dcaa61..f9c1758 100644
--- a/CentralAuthHooks.php
+++ b/CentralAuthHooks.php
@@ -306,7 +306,7 @@
} else {
if ( $wgCentralAuthLoginWiki ) {
// Set $inject_html to some text to bypass the
LoginForm redirection
- $inject_html .= wfMessage(
'centralauth-login-no-others' )->text();
+ $inject_html .= wfMessage(
'centralauth-login-no-others' )->escaped();
// Redirect to the central wiki and back to
complete login
$dummy = '';
self::doCentralLoginRedirect( $user,
$centralUser, $dummy );
@@ -329,10 +329,10 @@
// No other domains
if ( !$wgCentralAuthAutoLoginWikis ) {
- $inject_html = wfMessage( 'centralauth-login-no-others'
)->text();
+ $inject_html = wfMessage( 'centralauth-login-no-others'
)->escaped();
} else {
$inject_html = '<div class="centralauth-login-box"><p>'
.
- wfMessage( 'centralauth-login-progress',
$user->getName() )->text() . "</p>\n<p>";
+ wfMessage( 'centralauth-login-progress',
$user->getName() )->escaped() . "</p>\n<p>";
foreach ( $wgCentralAuthAutoLoginWikis as $alt =>
$wikiID ) {
$wiki = WikiMap::getWiki( $wikiID );
--
To view, visit https://gerrit.wikimedia.org/r/82864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eeaa7aa6a968514ab40fa485141b666505f6b07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
