jenkins-bot has submitted this change and it was merged.
Change subject: Hide NagOverlay after checkboxes are checked
......................................................................
Hide NagOverlay after checkboxes are checked
The nag overlay could be seen in the background of the image description
textarea when the textarea was focused (tested on Andrid Browser 4.2 and
Chrome for Android). This fixes it.
Change-Id: I9a95104ad0f7fce58b4290b01e0d3e8c1870612f
---
M javascripts/modules/uploads/NagOverlay.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/uploads/NagOverlay.js
b/javascripts/modules/uploads/NagOverlay.js
index 9f7e661..a2511f3 100644
--- a/javascripts/modules/uploads/NagOverlay.js
+++ b/javascripts/modules/uploads/NagOverlay.js
@@ -50,6 +50,7 @@
$next = $checkboxes.not( ':checked' ).eq( 0 );
disable( $checkbox );
if ( !$next.length ) {
+ self.hide();
self.emit( 'confirm' );
} else {
enable( $next );
--
To view, visit https://gerrit.wikimedia.org/r/82747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a95104ad0f7fce58b4290b01e0d3e8c1870612f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
