JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/83124
Change subject: Remove obsolete code from mf-toggle-dynamic.js
......................................................................
Remove obsolete code from mf-toggle-dynamic.js
checkHash() was redundant. Dynamic section loading is already handled in
section-toggle event callback (mf-toggle-dynamic.js) and scrolling to the
section is handled in wm_reveal_for_hash() (mf-toggle.js).
Change-Id: I47a51a765503e15ab0efe31d63f4e991bc2df579
---
M javascripts/modules/mf-toggle-dynamic.js
1 file changed, 1 insertion(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/24/83124/1
diff --git a/javascripts/modules/mf-toggle-dynamic.js
b/javascripts/modules/mf-toggle-dynamic.js
index 23e413d..7d54b3e 100644
--- a/javascripts/modules/mf-toggle-dynamic.js
+++ b/javascripts/modules/mf-toggle-dynamic.js
@@ -1,7 +1,5 @@
( function( M, $ ) {
- var
- toggle = M.require( 'toggle' ),
- currentPage;
+ var currentPage;
M.on( 'section-toggle', function( section_id ) {
var
@@ -17,21 +15,6 @@
}
} );
- function checkHash() {
- var hash = window.location.hash, el, section;
- if ( hash ) {
- section = currentPage.getSectionFromAnchor( hash.slice(
1 ) );
- if ( section ) {
- toggle.wm_toggle_section( section.index );
- }
- // force scroll if not scrolled (e.g. after subsection
is loaded)
- el = $( hash );
- if ( el.length ) {
- el[ 0 ].scrollIntoView( true );
- }
- }
- }
-
function refresh( page ) {
var references = page.getReferenceSection();
currentPage = page;
@@ -39,7 +22,6 @@
$( '#content_' + references.index ).html(
references.content ).data( 'loaded', true );
M.emit( 'references-loaded' );
}
- checkHash();
}
M.on( 'page-loaded', refresh );
--
To view, visit https://gerrit.wikimedia.org/r/83124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47a51a765503e15ab0efe31d63f4e991bc2df579
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
