Mwalker has submitted this change and it was merged.

Change subject: Revert "(bug 53443) disable Special:GlobalAllocation"
......................................................................


Revert "(bug 53443) disable Special:GlobalAllocation"

This reverts commit 7b9fec7cb84b0ef9ca7ab46edbddb6246c24e786.

There was a misconfiguration which caused a warning for every banner title
displayed on the GlobalAllocation page, this may have been responsible for the
OOM reported in bug 53443.

Change-Id: Ie2ab9b03029a866685d2c1d9b3ab53c3910af705
---
M CentralNotice.alias.php
M CentralNotice.hooks.php
M CentralNotice.php
3 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Mwalker: Looks good to me, approved



diff --git a/CentralNotice.alias.php b/CentralNotice.alias.php
index 284d5d4..e93879c 100644
--- a/CentralNotice.alias.php
+++ b/CentralNotice.alias.php
@@ -8,7 +8,9 @@
 /** English (English) */
 $specialPageAliases['en'] = array(
        'CentralNotice' => array( 'CentralNotice' ),
+       'CentralNoticeBanners' => array( 'CentralNoticeBanners' ),
        'CentralNoticeLogs' => array( 'CentralNoticeLogs' ),
+       'CNReporter' => array( 'CNReporter' ),
        'NoticeTemplate' => array( 'NoticeTemplate' ),
        'GlobalAllocation' => array( 'GlobalAllocation' ),
        'BannerAllocation' => array( 'BannerAllocation' ),
diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 1acb0c0..6bbb078 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -135,9 +135,7 @@
                $wgSpecialPages[ 'CentralNotice' ] = 'CentralNotice';
                $wgSpecialPageGroups[ 'CentralNotice' ] = 'wiki'; // Wiki data 
and tools
                $wgSpecialPages[ 'NoticeTemplate' ] = 'SpecialNoticeTemplate';
-               /* disabled, see bug 53443
                $wgSpecialPages[ 'GlobalAllocation' ] = 
'SpecialGlobalAllocation';
-               */
                $wgSpecialPages[ 'BannerAllocation' ] = 
'SpecialBannerAllocation';
                $wgSpecialPages[ 'CentralNoticeLogs' ] = 
'SpecialCentralNoticeLogs';
                $wgSpecialPages[ 'CentralNoticeBanners'] = 
'SpecialCentralNoticeBanners';
diff --git a/CentralNotice.php b/CentralNotice.php
index badbec1..408885c 100644
--- a/CentralNotice.php
+++ b/CentralNotice.php
@@ -188,12 +188,10 @@
                'type' => 'views',
                'message' => 'centralnotice-allocation',
        ),
-       /* disabled, see bug 53443
        'GlobalAllocation' => array(
                'type' => 'views',
                'message' => 'centralnotice-global-allocation',
        ),
-       */
        'CentralNoticeLogs' => array(
                'type' => 'views',
                'message' => 'centralnotice-logs',

-- 
To view, visit https://gerrit.wikimedia.org/r/83194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2ab9b03029a866685d2c1d9b3ab53c3910af705
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to