Mwjames has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/83376


Change subject: \SRF\Gallery jCarousel: No width/height set for items
......................................................................

\SRF\Gallery jCarousel: No width/height set for items

Add jcarousel/itemFallbackDimension according to [1]

[1] 
http://stackoverflow.com/questions/3784925/no-width-height-set-for-items-this-will-cause-an-infinite-loop-aborting

Change-Id: I320402cb616339d937fcbae6825cb738319a5f29
---
M formats/gallery/resources/ext.srf.gallery.carousel.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticResultFormats 
refs/changes/76/83376/1

diff --git a/formats/gallery/resources/ext.srf.gallery.carousel.js 
b/formats/gallery/resources/ext.srf.gallery.carousel.js
index fd03153..8db3ccb 100644
--- a/formats/gallery/resources/ext.srf.gallery.carousel.js
+++ b/formats/gallery/resources/ext.srf.gallery.carousel.js
@@ -63,6 +63,7 @@
                        return context.each( function() {
                                var util = new srf.util();
                                var $this = $( this ),
+                                       fallbackDimension = srf.settings.get( 
'wgThumbLimits' )[mw.user.options.get( 'thumbsize' )],
                                        carousel = $this.find( '.jcarousel' );
 
                                        util.spinner.hide( { context: $this } );
@@ -74,7 +75,8 @@
                                                        visible: parseInt( $( 
this ).attr( 'data-visible' ), 10 ),
                                                        wrap: $( this ).attr( 
'data-wrap' ),
                                                        vertical: $( this 
).attr( 'data-vertical' ) === 'true',
-                                                       rtl: $( this ).attr( 
'data-rtl' ) === 'true'
+                                                       rtl: $( this ).attr( 
'data-rtl' ) === 'true',
+                                                       itemFallbackDimension: 
fallbackDimension
                                                } );
                                        } );
                        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/83376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I320402cb616339d937fcbae6825cb738319a5f29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Mwjames <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to