Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/83388


Change subject: Log more Navigation Timing events on mobile
......................................................................

Log more Navigation Timing events on mobile

This patch sets the mobile Navigation Timing sampling factor to be a quarter
that of desktop by changing its value in EnterMobileMode. The intent is to
collect enough data points per minute to make Ganglia graphs more robust to
outliers.

Change-Id: Ic8f2d0ffd44bf4315ec4fa6cd7dca3b38edbe5b0
---
M wmf-config/mobile.php
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/88/83388/1

diff --git a/wmf-config/mobile.php b/wmf-config/mobile.php
index 05fa190..cd001c8 100644
--- a/wmf-config/mobile.php
+++ b/wmf-config/mobile.php
@@ -110,7 +110,9 @@
 
 // Hack to work around https://bugzilla.wikimedia.org/show_bug.cgi?id=35215
 $wgHooks['EnterMobileMode'][] = function() {
-       global $wgCentralHost, $wgCentralPagePath, $wgCentralBannerDispatcher, 
$wgCentralBannerRecorder, $wgCentralAuthCookieDomain;
+       global $wgCentralAuthCookieDomain, $wgCentralBannerDispatcher,
+               $wgCentralBannerRecorder, $wgCentralHost, $wgCentralPagePath,
+               $wgNavigationTimingSamplingFactor;
 
        $wgCentralHost = str_replace( 'meta.wikimedia.org', 
'meta.m.wikimedia.org', $wgCentralHost );
        $wgCentralPagePath = str_replace( 'meta.wikimedia.org', 
'meta.m.wikimedia.org', $wgCentralPagePath );
@@ -124,6 +126,10 @@
                $wgCentralAuthCookieDomain = 'meta.m.wikimedia.org';
        }
 
+       // Ensure enough datapoints are collected on mobile by sampling 4 times 
as
+       // many requests as on desktop (ori-l; 8-Sep-2013). Careful with this, 
please.
+       $wgNavigationTimingSamplingFactor /= 4;
+
        return true;
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/83388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8f2d0ffd44bf4315ec4fa6cd7dca3b38edbe5b0
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to