EBernhardson (WMF) has submitted this change and it was merged.
Change subject: Don't unhide when declining oversight
......................................................................
Don't unhide when declining oversight
Rationaly was to auto-unhide entries that were auto-hidden as a result of the
oversight request.
For oversighters, this is confusing though, since they can't know the specific
outcome (still hidden or not?) of their decline-action.
Change-Id: I4d1027e6893755fdd416617ca7d49ff72fe820c4
---
M ArticleFeedbackv5.flagging.php
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
EBernhardson (WMF): Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/ArticleFeedbackv5.flagging.php b/ArticleFeedbackv5.flagging.php
index ca25ade..2715abd 100644
--- a/ArticleFeedbackv5.flagging.php
+++ b/ArticleFeedbackv5.flagging.php
@@ -253,13 +253,6 @@
$this->feedback->aft_decline = 1;
$this->logId = $this->log( __FUNCTION__,
$this->feedback->aft_page, $this->feedback->aft_id, $notes, $this->user );
- // un-hide if autohidden
- if ( $this->feedback->aft_hide && $this->feedback->aft_autohide
) {
- $this->feedback->aft_hide = 0;
- $this->feedback->aft_autohide = 0;
- $this->log( 'unhide', $this->feedback->aft_page,
$this->feedback->aft_id, 'Automatic un-hide', $this->user );
- }
-
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/80545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1027e6893755fdd416617ca7d49ff72fe820c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: EBernhardson (WMF) <ebernhard...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
