Petr Onderka has submitted this change and it was merged.
Change subject: Removed check for trailing zero in decompressed string
......................................................................
Removed check for trailing zero in decompressed string
With compressed groups, missing trailing zero is problematic.
On the other hand, added trailing zero is now okay.
Change-Id: Ia368b7ef2a198ee327029704e0a19f5b4ae7f84f
---
M SevenZip.cpp
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Petr Onderka: Verified; Looks good to me, approved
diff --git a/SevenZip.cpp b/SevenZip.cpp
index 04a403f..b9fe86f 100644
--- a/SevenZip.cpp
+++ b/SevenZip.cpp
@@ -63,10 +63,5 @@
std::string decompressedString = outputStdStream.str();
- // LZMA decompression seems to sometimes introduce trailing 0 byte
- // this takes care of that
- if (!decompressedString.empty() && decompressedString.back() == '\0')
- decompressedString.pop_back();
-
return decompressedString;
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/83788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia368b7ef2a198ee327029704e0a19f5b4ae7f84f
Gerrit-PatchSet: 1
Gerrit-Project: operations/dumps/incremental
Gerrit-Branch: gsoc
Gerrit-Owner: Petr Onderka <[email protected]>
Gerrit-Reviewer: Petr Onderka <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
