jenkins-bot has submitted this change and it was merged.
Change subject: Make navigation.js load at the top
......................................................................
Make navigation.js load at the top
And ensure that mobile.head module loads at the top too. This might fix
bug 53511 or at least make it less annoying.
Bug: 53511
Change-Id: I81945dd0723b4c6fb67cc5e8e687a5aa3000ad2e
---
M includes/Resources.php
M includes/skins/SkinMinerva.php
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index 5a6fe91..e80141f 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -131,6 +131,7 @@
'scripts' => array(
'javascripts/common/polyfills.js',
'javascripts/common/modules.js',
+ 'javascripts/common/navigation.js',
),
'position' => 'top',
),
@@ -404,7 +405,6 @@
'javascripts/common/CtaDrawer.js',
'javascripts/common/Overlay.js',
'javascripts/widgets/progress-bar.js',
- 'javascripts/common/navigation.js',
'javascripts/common/notification.js',
'javascripts/views/page.js',
// Upload specific code
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 0fab93d..dc1970e 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -211,6 +211,7 @@
$out = $this->getOutput();
$modules['mobile'] = array(
+ 'mobile.head',
'mobile.startup',
'mobile.site',
// FIXME: separate mobile.stable into more meaningful
groupings
--
To view, visit https://gerrit.wikimedia.org/r/83207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81945dd0723b4c6fb67cc5e8e687a5aa3000ad2e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
