KartikMistry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/83997
Change subject: WIP: Integration tests for off-screen IME selector.
......................................................................
WIP: Integration tests for off-screen IME selector.
Change-Id: I0b3253ba9cb19afae41612435ef0a9604814f3ed
---
M tests/browser/features/step_definitions/common_steps.rb
M tests/browser/features/step_definitions/uls_ime_steps.rb
A tests/browser/features/support/pages/ascii_mono.rb
A tests/browser/features/support/pages/ascii_vector.rb
M tests/browser/features/uls_ime.feature
5 files changed, 64 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/97/83997/1
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 57b7e1f..1fa46b2 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -48,6 +48,8 @@
'en'
when 'Finnish'
'fi'
+ when 'Hebrew'
+ 'he'
else
pending
end
diff --git a/tests/browser/features/step_definitions/uls_ime_steps.rb
b/tests/browser/features/step_definitions/uls_ime_steps.rb
index c5603ae..36bdfb7 100644
--- a/tests/browser/features/step_definitions/uls_ime_steps.rb
+++ b/tests/browser/features/step_definitions/uls_ime_steps.rb
@@ -70,3 +70,18 @@
# 'input_method_enabled' alone only returns []
on(RandomPage).input_method_enabled_element.text.should == 'ഇൻസ്ക്രിപ്റ്റ് 2'
end
+
+When(/^I visit page in Vector skin$/) do
+ sleep 1.0;
+ visit(AsciiVector)
+end
+
+When(/^I visit page in Monobook skin$/) do
+ sleep 1.0;
+ visit(AsciiMono)
+end
+
+Then(/^I should see the input method menu is not offscreen$/) do
+ #WIP
+ #Code need to check offset.
+end
diff --git a/tests/browser/features/support/pages/ascii_mono.rb
b/tests/browser/features/support/pages/ascii_mono.rb
new file mode 100644
index 0000000..43211c7
--- /dev/null
+++ b/tests/browser/features/support/pages/ascii_mono.rb
@@ -0,0 +1,9 @@
+class AsciiMono
+ include PageObject
+
+ include URL
+ def self.url
+ URL.url('ASCII?useskin=monobook')
+ end
+ page_url url
+end
diff --git a/tests/browser/features/support/pages/ascii_vector.rb
b/tests/browser/features/support/pages/ascii_vector.rb
new file mode 100644
index 0000000..9eca485
--- /dev/null
+++ b/tests/browser/features/support/pages/ascii_vector.rb
@@ -0,0 +1,9 @@
+class AsciiVector
+ include PageObject
+
+ include URL
+ def self.url
+ URL.url('ASCII?useskin=vector')
+ end
+ page_url url
+end
diff --git a/tests/browser/features/uls_ime.feature
b/tests/browser/features/uls_ime.feature
index 31f8c48..0f3b109 100644
--- a/tests/browser/features/uls_ime.feature
+++ b/tests/browser/features/uls_ime.feature
@@ -49,3 +49,32 @@
And I press Control-M
Then I should see the input method indicator
And in it there must be an element with Malayalam text
+
+ @login @reset-preferences-after
+ Scenario: Input method menu is not offscreen
+
+ Input method indicator is not offscreen for English and RTL languages.
+
+ Given I am logged in
+ Given I set "English" as the interface language
+ When I visit page in Vector skin
+ And I open the input method menu
+ Then I should see the input method menu is not offscreen
+
+ Given I am logged in
+ Given I set "Hebrew" as the interface language
+ When I visit page in Monobook skin
+ And I open the input method menu
+ Then I should see the input method menu is not offscreen
+
+ Given I am logged in
+ Given I set "English" as the interface language
+ When I visit page in Monobook skin
+ And I open the input method menu
+ Then I should see the input method menu is not offscreen
+
+ Given I am logged in
+ Given I set "Hebrew" as the interface language
+ When I visit page in Vector skin
+ And I open the input method menu
+ Then I should see the input method menu is not offscreen
--
To view, visit https://gerrit.wikimedia.org/r/83997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b3253ba9cb19afae41612435ef0a9604814f3ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: KartikMistry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
