Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/84298
Change subject: Make removeClaimsEntityId check case insenstive
......................................................................
Make removeClaimsEntityId check case insenstive
Change-Id: Idd98d9d9e8c6843002510ee9ff95f1c260bea57e
---
M repo/includes/api/RemoveClaims.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/98/84298/1
diff --git a/repo/includes/api/RemoveClaims.php
b/repo/includes/api/RemoveClaims.php
index 8674260..4cdc7a2 100644
--- a/repo/includes/api/RemoveClaims.php
+++ b/repo/includes/api/RemoveClaims.php
@@ -82,6 +82,7 @@
* @return EntityId
*/
protected function getEntityId( array $params ) {
+ $claimGuidParser =
WikibaseRepo::getDefaultInstance()->getClaimGuidParser();
$entityId = null;
foreach ( $params['claim'] as $guid ) {
@@ -90,11 +91,11 @@
}
if ( !is_null( $entityId ) ) {
- if ( Entity::getIdFromClaimGuid( $guid ) !==
$entityId ) {
+ if ( !$claimGuidParser->parse( $guid
)->getEntityId()->equals( $entityId ) ) {
$this->dieUsage( 'All claims must
belong to the same entity' , 'invalid-guid' );
}
} else {
- $entityId = Entity::getIdFromClaimGuid( $guid );
+ $entityId = $claimGuidParser->parse( $guid );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/84298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd98d9d9e8c6843002510ee9ff95f1c260bea57e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
