jenkins-bot has submitted this change and it was merged.
Change subject: Triggering claimview's "change" event when qualifier snaks are
reordered
......................................................................
Triggering claimview's "change" event when qualifier snaks are reordered
Change-Id: Ide80d2af97ee4a0146a64daf5fb58f9d0504ff17
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
M lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
index 864f6e2..5d9aad2 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
@@ -206,9 +206,12 @@
} ),
value: groupedQualifierSnaks
} )
- .on( 'snaklistviewchange.' + this.widgetName, function(
event ) {
- self._trigger( 'change' );
- } )
+ .on( 'snaklistviewchange.' + this.widgetName
+ + ' listviewafteritemmove.' + this.widgetName,
+ function( event ) {
+ self._trigger( 'change' );
+ }
+ )
.on( 'listviewitemremoved.' + this.widgetName,
function( event, value, $itemNode ) {
if( event.target ===
self._qualifiers.element.get( 0 ) ) {
self._trigger( 'change' );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
index 0dd71c9..ddbb194 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
@@ -167,6 +167,7 @@
} );
} )
.on( this._lia.prefixedEvent( 'change.' ) + this.widgetName
+ + ' listviewafteritemmove.' + this.widgetName
+ ' listviewitemremoved.' + this.widgetName, function(
event ) {
// Forward the "change" event to external
components (e.g. the edit toolbar).
self._trigger( 'change' );
--
To view, visit https://gerrit.wikimedia.org/r/84521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide80d2af97ee4a0146a64daf5fb58f9d0504ff17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
