jenkins-bot has submitted this change and it was merged.
Change subject: Remove ve.log debugging calls from EventSequencer
......................................................................
Remove ve.log debugging calls from EventSequencer
Change-Id: I642acf09e7ed52d6dbf4312e054134b264c3428d
---
M modules/ve/ve.EventSequencer.js
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Divec: Looks good to me, but someone else must approve
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ve.EventSequencer.js b/modules/ve/ve.EventSequencer.js
index cba7ff8..1d0d5de 100644
--- a/modules/ve/ve.EventSequencer.js
+++ b/modules/ve/ve.EventSequencer.js
@@ -136,12 +136,10 @@
*/
ve.EventSequencer.prototype.onEvent = function ( eventName, ev ) {
var i, len, onListener, afterListener, pendingCall;
- ve.log( 'EventSequencer: onEvent', eventName, ev );
this.runPendingCalls();
// Length cache 'len' is required, as an onListener could add another
onListener
for ( i = 0, len = this.onListenersForEvent[eventName].length; i < len;
i++ ) {
onListener = this.onListenersForEvent[eventName][i];
- ve.log( 'EventSequencer: on ', eventName, ev );
onListener( ev );
}
// Length cache 'len' for style only
@@ -162,7 +160,6 @@
return;
}
pendingCall.id = null;
- ve.log( 'EventSequencer: timed: after',
eventName, ev );
pendingCall.func( ev );
} );
pendingCall.id = id;
@@ -179,7 +176,6 @@
*/
ve.EventSequencer.prototype.runPendingCalls = function () {
var i, pendingCall;
- ve.log( 'EventSequencer: runPendingCalls', this.pendingCalls );
for ( i = 0; i < this.pendingCalls.length; i++ ) {
// Length cache not possible, as a pending call appends another
pending call.
// It's important that this list remains mutable, in the case
that this
@@ -191,7 +187,6 @@
}
clearTimeout( pendingCall.id );
pendingCall.id = null;
- ve.log( 'EventSequencer: forced: after', pendingCall );
// Force to run now. It's important that we set id to null
before running,
// so that there's no chance a recursive call will call the
listener again.
pendingCall.func( pendingCall.ev );
--
To view, visit https://gerrit.wikimedia.org/r/84367
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I642acf09e7ed52d6dbf4312e054134b264c3428d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Divec <da...@sheetmusic.org.uk>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
