Mwalker has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/84673


Change subject: Bugfix where variable wasnt defined for translation groups
......................................................................

Bugfix where variable wasnt defined for translation groups

This caused lots of ugly warnings and general evil.

Change-Id: Id94b404269bfe908636492ce4bb4e43d50f1542d
---
M includes/Banner.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/73/84673/1

diff --git a/includes/Banner.php b/includes/Banner.php
index 9319485..111bb22 100644
--- a/includes/Banner.php
+++ b/includes/Banner.php
@@ -1166,7 +1166,7 @@
                        'rt_revision' => $revisionId
                );
 
-               if ( $value !== null ) {
+               if ( $bannerId !== null ) {
                        $conds['rt_value'] = $bannerId;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/84673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id94b404269bfe908636492ce4bb4e43d50f1542d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to